Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude reporting type declarations passed as call arguments #450

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Exclude reporting type declarations passed as call arguments #450

merged 1 commit into from
Jan 18, 2024
+20 −5

Conversation

Sija
Copy link
Member

@Sija Sija commented Jan 17, 2024

Resolves #447

@Sija Sija added this to the 1.6.2 milestone Jan 17, 2024
@Sija Sija self-assigned this Jan 17, 2024
@Sija Sija requested a review from veelenga January 17, 2024 23:35
@Sija Sija enabled auto-merge January 17, 2024 23:36
veelenga
veelenga approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit 7f50ff9 into master Jan 18, 2024
4 checks passed
@Sija Sija deleted the fix-issue-447 branch January 18, 2024 06:52
@straight-shoota straight-shoota mentioned this pull request Jan 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
false positive
Projects
None yet
Milestone
1.6.2
Development

Successfully merging this pull request may close these issues.

Lint/UselessAssign reports macros accepting Crystal::Macros::TypeDeclaration
2 participants
@Sija @veelenga